fix: load runtime data using importlib.resources.files#216
fix: load runtime data using importlib.resources.files#216sbillinge merged 3 commits intodiffpy:mainfrom
importlib.resources.files#216Conversation
|
@sbillinge ready for review |
|
This is good to know... How will we remember this again in the future? I wonder if we could write a short FAQ in scikit-package that summarizes what we did here (data in a dir outside src but packaged with the sdist and the wheel - as long as it is needed at runtime and is small) then how to update the pyproject.toml and manifest and imports to make it all work..... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 5 5
Lines 345 345
=======================================
Hits 342 342
Misses 3 3 🚀 New features to boost your workflow:
|
|
@cadenmyers13 do we want to do an rc release to see if this package builds correctly? |
@sbillinge I created an issue to do this in scikit-package. PS the data is inside
Yeah lets do it. |
|
I pushed out |
closes #211
As recommended on that issue ^